This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
Add binaryUpdateCallback to checkForUpdate & sync methods #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #260.
As per #260 (comment) this PR adds an additional callback to codePush.sync & checkForUpdate methods in a similar vein as react-native-code-push.
All the changes are purely additive, so no breaking changes. This does mean the syncCallback is still called with status UP_TO_DATE (directly after the newly added
binaryUpdateCallbackis called).The binaryUpdateCallback is called with a NativeUpdateNotification object. Unfortunately this object doesn't contain a lot of useful info (only the binary target as
appVersion). Other RemotePackage properties, such as isMandatory for example, are missing. To change/improve this, would require making changes to the (parent)code-pushrepo, specifically around this line. This may be considered as further action.