This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
Update the build-extras.gradle file #599
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cordova Jira Ticket Exapling the Bug this fixes https://issues.apache.org/jira/browse/CB-14163 We had trouble using this plugin on android with other plugins that also try to use ext.postBuildExtras. We had cordova-support-google-services and cordova-plugin-code-push installed as well as this plugin and all three were trying to use postBuildExtras. But only the last plugin listed in our config file would have its code executed at built time. the link above describes the cause of the issue pretty well
|
Any plans to merge this? |
|
@alexandergoncharov I'd like to emphasize the necessity of this update. Without it, you can't use phonegap-plugin-push in the same build. We've forked this plugin for our internal use, but it's a real issue for anybody that's not aware of it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cordova Jira Ticket Exapling the Bug this fixes
https://issues.apache.org/jira/browse/CB-14163
We had trouble using this plugin on android with other plugins that also try to use ext.postBuildExtras.
We had cordova-support-google-services and cordova-plugin-code-push installed as well as this plugin and all three were trying to use postBuildExtras.
But only the last plugin listed in our config file would have its code executed at built time. the link above describes the cause of the issue pretty well