Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Speech and code refactor #199

Merged
merged 13 commits into from
Oct 3, 2023
Merged

add Speech and code refactor #199

merged 13 commits into from
Oct 3, 2023

Conversation

thivy
Copy link
Contributor

@thivy thivy commented Oct 3, 2023

No description provided.

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 3, 2023
View reviewed changes
infra/resources.bicep Dismissed Show dismissed Hide dismissed
infra/resources.bicep Dismissed Show dismissed Hide dismissed
infra/resources.bicep
@@ -351,5 +370,18 @@
}
}]

resource speechService 'Microsoft.CognitiveServices/accounts@2023-05-01' = {

Check failure

Code scanning / templateanalyzer

Use Managed Identity for Cogitive Services accounts. Error

Cognitive Services must authenticate to Azure resources such storage accounts. To authenticate to Azure resources, Cognitive Services can use managed identities.
Using Azure managed identities have the following benefits: You don't need to store or manage credentials.
Azure automatically generates tokens and performs rotation. You can use managed identities to authenticate to any Azure service that supports Azure AD authentication. Managed identities can be used without any additional cost.
infra/resources.bicep Dismissed Show dismissed Hide dismissed
infra/resources.bicep Dismissed Show dismissed Hide dismissed
@davidxw davidxw merged commit c473210 into main Oct 3, 2023
2 of 3 checks passed
Sandeep-FED pushed a commit to Sandeep-FED/azurechat that referenced this pull request Jun 14, 2024
@davidxw
Merge pull request microsoft#199 from microsoft/speech
1575e7b 
add Speech and code refactor
Sandeep-FED pushed a commit to Sandeep-FED/azurechat that referenced this pull request Jun 14, 2024
@davidxw
Merge pull request microsoft#199 from microsoft/speech
c4d7ae4 
add Speech and code refactor
jnxjent pushed a commit to jnxjent/azurechat that referenced this pull request Aug 26, 2024
@davidxw
Merge pull request microsoft#199 from microsoft/speech
c122db5 
add Speech and code refactor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidxw davidxw davidxw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thivy @davidxw