Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WinUI3 logo #4922

Closed
wants to merge 1 commit into from
Closed

Update WinUI3 logo #4922

wants to merge 1 commit into from

Conversation

Lamparter
Copy link

Hello!
This is a community follow-up PR to microsoft/microsoft-ui-xaml#10189 where the WinUI3 logo is being updated 🎉
In this PR I've replaced the logo with the new one in all the places I could find (shoutout to @ghost1372 for helping me out) - please let me know if I've missed anywhere!


A microsoft employee must use /azp run to validate using the pipelines below.

WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.

For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.

@ghost1372
Copy link
Contributor

Thank you @Lamparter for you PR
But it is still not clear which icon was chosen for the template. Because we have a separate icon for WASDK
image

@Lamparter
Copy link
Author

The app template is an app that uses WinUI3 (the design system) so I imagined that the logo should be the winui3 one and not the WinAppSDK one.

@Lamparter
Copy link
Author

@ghost1372 do you know where else the logo might be?

@0x5bfa
Copy link

0x5bfa commented Nov 28, 2024

What about NuGet's icon: https://www.nuget.org/packages/Microsoft.WindowsAppSdk/
It's currently Windows logo but should be the new one.
I guess here? https://github.com/microsoft/WindowsAppSDK/tree/main/assets

@ghost1372
Copy link
Contributor

What about NuGet's icon: https://www.nuget.org/packages/Microsoft.WindowsAppSdk/ It's currently Windows logo but should be the new one. I guess here? https://github.com/microsoft/WindowsAppSDK/tree/main/assets

yes final step is nuget package icon

@ghost1372
Copy link
Contributor

@ghost1372 do you know where else the logo might be?

i think nuget package should use wasdk icon

@niels9001
Copy link

niels9001 commented Nov 28, 2024

Hey everyone! I love the initiative here and the effort you’ve put into it—it’s fantastic to see! We’ve also been exploring ways to enhance the iconography for project and item templates to make them more distinguishable and improve accessibility. I’ve created a tracking issue here: #4923, and we’ll be submitting a PR with the new icons soon. Looking forward to collaborating on this!

Update: PR is up #4924

@0x5bfa
Copy link

0x5bfa commented Nov 28, 2024

I think this PR was superseded by #4924

@Lamparter
Copy link
Author

@niels9001 would you like me to close this PR?

@Lamparter Lamparter closed this Nov 28, 2024
@Lamparter Lamparter deleted the logo branch November 28, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants