Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the way "inherited" workspaces retrieve the base workspace code #4190

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jonnyry
Copy link
Collaborator

@jonnyry jonnyry commented Dec 11, 2024

Resolves #4162

What is being addressed

Change the way inherited workspaces retrieve the base workspace code - see solution description in #4162

Notes

  1. Currently requires the 'canary' release of porter. Ideally this should be a pinned version, however we are waiting for a new version release which includes the --build-context parameter.

@jonnyry jonnyry requested a review from marrobi December 11, 2024 17:27
Copy link

github-actions bot commented Dec 11, 2024

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit f6255a6.

♻️ This comment has been updated with latest results.

@tim-allen-ck
Copy link
Collaborator

tim-allen-ck commented Dec 12, 2024

so do you need to have built base first? Will it just use the latest version of base?

@jonnyry
Copy link
Collaborator Author

jonnyry commented Dec 12, 2024

so do you need to have built base first? Will it just use the latest version of base?

you don't need to have base built first, it pulls the latest files from the ../base directory, by using the 'base' --build-context passed to porter build.

@tim-allen-ck
Copy link
Collaborator

so do you need to have built base first? Will it just use the latest version of base?

you don't need to have base built first, it pulls the latest files from the ../base directory, by using the 'base' --build-context passed to porter build.

Ahh got you. Nice. Happy to approve will test later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the way "inherited" workspaces retrieve the base workspace code
2 participants