Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support plan mode deployment #4047

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Support plan mode deployment #4047

wants to merge 8 commits into from

Conversation

marrobi
Copy link
Member

@marrobi marrobi commented Jul 31, 2024

Related to #4029

Add support for 'plan' mode deployments to evaluate the terraform plan before applying it.

  • devops/scripts/terraform_wrapper.sh

    • Add a check for the DEPLOY_MODE variable.
    • Execute terraform plan without applying if DEPLOY_MODE is set to 'plan'.
    • Log the plan output to a file.
  • docs/tre-admins/setup-instructions/manual-deployment.md

    • Add instructions on using the DEPLOY_MODE variable for 'plan' mode deployments.
    • Include examples of setting the DEPLOY_MODE variable to 'plan' and 'apply'.
  • .github/workflows/deploy_tre.yml

    • Add an input for DEPLOY_MODE in the workflow.
    • Pass the DEPLOY_MODE input to the deployment script.
  • docs/tre-admins/setup-instructions/workflows.md

    • Add instructions on using the DEPLOY_MODE variable for 'plan' mode deployments via the GitHub UI.
    • Include examples of setting the DEPLOY_MODE variable to 'plan' and 'apply'.

For more details, open the Copilot Workspace session.

* **.github/workflows/deploy_tre.yml**
  - Add an input for `DEPLOY_MODE` in the workflow
  - Pass the `DEPLOY_MODE` input to the deployment script

* **docs/tre-admins/setup-instructions/workflows.md**
  - Add instructions on using the `DEPLOY_MODE` variable for 'plan' mode deployments via the GitHub UI

* **devops/scripts/terraform_wrapper.sh**
  - Add a check for the `DEPLOY_MODE` variable
  - Execute `terraform plan` without applying if `DEPLOY_MODE` is set to 'plan'
  - Log the plan output to a file

* **docs/tre-admins/setup-instructions/manual-deployment.md**
  - Add instructions on using the `DEPLOY_MODE` variable for 'plan' mode deployments
  - Include examples of setting the `DEPLOY_MODE` variable to 'plan' and 'apply'
Related to #4029

Add support for 'plan' mode deployments to evaluate the terraform plan before applying it.

* **devops/scripts/terraform_wrapper.sh**
  - Add a check for the `DEPLOY_MODE` variable.
  - Execute `terraform plan` without applying if `DEPLOY_MODE` is set to 'plan'.
  - Log the plan output to a file.

* **docs/tre-admins/setup-instructions/manual-deployment.md**
  - Add instructions on using the `DEPLOY_MODE` variable for 'plan' mode deployments.
  - Include examples of setting the `DEPLOY_MODE` variable to 'plan' and 'apply'.

* **.github/workflows/deploy_tre.yml**
  - Add an input for `DEPLOY_MODE` in the workflow.
  - Pass the `DEPLOY_MODE` input to the deployment script.

* **docs/tre-admins/setup-instructions/workflows.md**
  - Add instructions on using the `DEPLOY_MODE` variable for 'plan' mode deployments via the GitHub UI.
  - Include examples of setting the `DEPLOY_MODE` variable to 'plan' and 'apply'.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/AzureTRE/issues/4029?shareId=XXXX-XXXX-XXXX-XXXX).
@marrobi marrobi changed the base branch from marrobi/marrobi-issue4029 to main November 6, 2024 13:30
@marrobi marrobi linked an issue Nov 6, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Nov 6, 2024

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit a05ec96.

♻️ This comment has been updated with latest results.

@marrobi marrobi marked this pull request as ready for review November 15, 2024 11:19
Copy link
Collaborator

@tim-allen-ck tim-allen-ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support "plan" mode deployment
2 participants