-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support "plan" mode deployment #4029
Comments
this would be great. |
Related to #4029 Add support for 'plan' mode deployments to evaluate the terraform plan before applying it. * **devops/scripts/terraform_wrapper.sh** - Add a check for the `DEPLOY_MODE` variable. - Execute `terraform plan` without applying if `DEPLOY_MODE` is set to 'plan'. - Log the plan output to a file. * **docs/tre-admins/setup-instructions/manual-deployment.md** - Add instructions on using the `DEPLOY_MODE` variable for 'plan' mode deployments. - Include examples of setting the `DEPLOY_MODE` variable to 'plan' and 'apply'. * **.github/workflows/deploy_tre.yml** - Add an input for `DEPLOY_MODE` in the workflow. - Pass the `DEPLOY_MODE` input to the deployment script. * **docs/tre-admins/setup-instructions/workflows.md** - Add instructions on using the `DEPLOY_MODE` variable for 'plan' mode deployments via the GitHub UI. - Include examples of setting the `DEPLOY_MODE` variable to 'plan' and 'apply'. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/AzureTRE/issues/4029?shareId=XXXX-XXXX-XXXX-XXXX).
@jonnyry been playing with GitHub Workspaces to fix issues. Created a PR, but haven't tested it. Let me know thoughts and if can find time to test, would be great. |
@marrobi ah fantastic - thank you very much :-) just returned from holiday but will test it out soon. |
Sorry for taking so long to look at this... Tested for a local For a However in the full |
@jonnyry is this an issue as the new versions of the API and UI would only be deployed once the versions have been incremented by terraform apply? I know of some people who have the image builds in separate pipelines to the main Terraform deployment. Do you think any issues might be caused by and/or is it useful merging it as is? |
@jonnyry any suggestions for improvement to this, or should I look to get it merged? One way to handle the CI scenario, would be a separate pipeline dedication to running plan on |
Hi @marrobi
OK I hadn't realised that. How about workspace / workspace service template images - would these be pushed to the ACR (if running as CICD)? My main concern is the potential for leaving the infrastructure in an inconsistent state. Unfortunately I haven't had time to test again and look at which componenets are updated or not on a full CICD build. |
Support "plan" mode deployments so that you can evaluate the terraform plan before deciding to apply it.
Upgrading a TRE between versions may change a large number of Azure resources which introduces risk to a running TRE. Being able to evaluate the terraform plan before applying would reduce the risk of issues occuring during an upgrade, and the downtime required for an upgrade.
Ideally this would be a new build variable, e.g.
Also: a similar mode when upgrading components within the TRE.
The text was updated successfully, but these errors were encountered: