Get artifacts for version 'latest' from the last successful CICD run on the corresponding branch #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mazhelez
changed the title
aholstrup1
reviewed
Nov 7, 2023
There was a problem hiding this comment.
Looks good overall I think 👍
In the future.. I wonder if we should investigate publishing CI/CD artifacts to GitHub packages instead. I'm guessing finding artifacts for 'latest' or for 'specific version' would be significantly easier if the artifacts are in a nuget feed.
freddydk
reviewed
Nov 7, 2023
freddydk
reviewed
Nov 7, 2023
mazhelez
changed the title
freddydk
requested changes
Nov 12, 2023
mazhelez
changed the title
freddydk
requested changes
Nov 16, 2023
… into fix-getdependencies
freddydk
approved these changes
Nov 17, 2023
elbardel
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues: Currently, the artifacts are fetched through the artifacts API, which means that for version 'latest' some artifacts may be picked from the latest CICD run that succeeded partially, while others — from a previous CICD run that succeeded. This could lead to a lot of issues for both incremental builds (PR builds) and releasing 'latest' version.
Solution:
When getting artifacts via
GetArtifacts, use only artifacts from the latest successful CICD run when the version is 'latest'.CICD is considered successful if the build jobs succeeded.
Note: GitHub API returns the workflow runs ordered by
created_datein descending order.