Merge branch 'main' into CheckForUpdates

Actions/Github-Helper.psm1

@@ -729,6 +729,10 @@ function GetArtifacts {
     # Use buildOutput artifact to determine the workflow run id to avoid excessive API calls
     # Reason: A project called xx-main will match the artifact pattern *-main-*-version, and there might not be any artifacts matching the mask
     $buildOutputPattern = "*-$branch-BuildOutput-$version"
+    # Old builds from PR runs are vresioned differently and should be ignored
+    $ignoreBuildOutputPattern1 = "*-$branch-BuildOutput-*.*.2147483647.0"
+    # Build Output from TestCurrent, TestNextMinor and TestNextMajor are named differently and should be ignored
+    $ignoreBuildOutputPattern2 = "*-$branch-BuildOutput-*-*"
     Write-Host "Analyzing artifacts matching $artifactPattern"
     while ($true) {
         if ($total_count -eq 0) {
@@ -754,7 +758,7 @@ function GetArtifacts {
             continue
         }
         $matchingArtifacts += @($artifacts.artifacts | Where-Object { !$_.expired -and $_.name -like $artifactPattern })
-        $buildOutputArtifacts += @($artifacts.artifacts | Where-Object { !$_.expired -and $_.name -like $buildOutputPattern })
+        $buildOutputArtifacts += @($artifacts.artifacts | Where-Object { !$_.expired -and $_.name -like $buildOutputPattern -and $_.name -notlike $ignoreBuildOutputPattern1 -and $_.name -notlike $ignoreBuildOutputPattern2 })
         if ($buildOutputArtifacts.Count -gt 0) {
             # We have matching artifacts.
             # If the last artifact in the list of artifacts read is not from the same workflow run, there are no more matching artifacts
@@ -788,6 +792,7 @@ function GetArtifacts {
     if (-not $result) {
         Write-Host "- No matching artifacts found"
     }
+    $result
 }
 
 function DownloadArtifact {

README.md

@@ -9,10 +9,11 @@ The template repositories to use as starting point are:
 - [https://github.com/microsoft/AL-Go-PTE](https://github.com/microsoft/AL-Go-PTE) or [https://aka.ms/algopte](https://aka.ms/algopte) is the GitHub repository template for Per Tenant Extensions. When creating a Per Tenant Extensions, this is your starting point.
 - [https://github.com/microsoft/AL-Go-AppSource](https://github.com/microsoft/AL-Go-AppSource) or [https://aka.ms/algoappsource](https://aka.ms/algoappsource) is the GitHub repository template for AppSource apps. When creating an AppSource App, this is your starting point.
 
+## AL-Go Workshop
 
-The below usage scenarios takes you through how to get started and how to perform the most common tasks.
+Try out the [AL-Go workshop](https://aka.ms/algoworkshop) for an in-depth workshop on AL-Go for GitHub functionality or examine the below usage scenarios, which explains how to get started and how to perform the most common tasks.
 
-## Usage scenarios:
+## Usage scenarios
 1. [Create a new per-tenant extension (like AL Go) and start developing in VS Code](Scenarios/GetStarted.md)
 2. [Add a test app to an existing project](Scenarios/AddATestApp.md)
 3. [Register a customer sandbox environment for Continuous Deployment using S2S](Scenarios/RegisterSandboxEnvironment.md)

Templates/AppSource App/.github/workflows/PullRequestHandler.yaml

@@ -99,6 +99,7 @@ jobs:
       projectDependenciesJson: ${{ needs.Initialization.outputs.projectDependenciesJson }}
       secrets: 'licenseFileUrl,keyVaultCertificateUrl,*keyVaultCertificatePassword,keyVaultClientId,gitHubPackagesContext,applicationInsightsConnectionString'
       publishThisBuildArtifacts: ${{ needs.Initialization.outputs.workflowDepth > 1 }}
+      artifactsNameSuffix: 'PR${{ github.event.number }}'
 
   StatusCheck:
     needs: [ Initialization, Build ]

Templates/Per Tenant Extension/.github/workflows/PullRequestHandler.yaml

@@ -99,6 +99,7 @@ jobs:
       projectDependenciesJson: ${{ needs.Initialization.outputs.projectDependenciesJson }}
       secrets: 'licenseFileUrl,keyVaultCertificateUrl,*keyVaultCertificatePassword,keyVaultClientId,gitHubPackagesContext,applicationInsightsConnectionString'
       publishThisBuildArtifacts: ${{ needs.Initialization.outputs.workflowDepth > 1 }}
+      artifactsNameSuffix: 'PR${{ github.event.number }}'
 
   StatusCheck:
     needs: [ Initialization, Build ]