Revert "fix: don’t leakage Micronaut Validation (#1267)" #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2dcf574.
|
sdelamo
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 2dcf574 which was from #1267
When we stopped leaking micronaut-validation, we made a breaking change that broke the
@DateCreatedannotation in micronaut-data.The events that are fired to in-fill these annotated values require a validatorfactory to fire, and so downstream users need to add one of
io.micronaut.validation:micronaut-validationorio.micronaut.beanvalidation:micronaut-hibernate-validatorto their builds...We will revert this change for Micronaut 4.3.7 (v5.5.2 of this module), and revisit for Micronaut 5 where breakages can be expected and documented