Byte code generator #167
Open
Byte code generator #167
+10,328
−1,014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graemerocher
requested changes
Oct 29, 2024
sourcegen-generator-bytecode/src/main/java/io/micronaut/sourcegen/ByteCodeGenerator.java
Outdated
Show resolved
Hide resolved
sourcegen-generator-bytecode/src/main/java/io/micronaut/sourcegen/ByteCodeGenerator.java
Outdated
Show resolved
Hide resolved
sourcegen-generator-bytecode/src/main/java/io/micronaut/sourcegen/ByteCodeGenerator.java
Outdated
Show resolved
Hide resolved
sourcegen-generator-bytecode/src/main/java/io/micronaut/sourcegen/ByteCodeGenerator.java
Outdated
Show resolved
Hide resolved
sourcegen-generator-bytecode/src/main/java/io/micronaut/sourcegen/ByteCodeGenerator.java
Outdated
Show resolved
Hide resolved
sourcegen-generator-bytecode/src/main/java/io/micronaut/sourcegen/ByteCodeGenerator.java
Outdated
Show resolved
Hide resolved
| throw new IllegalStateException("Field " + field.name() + " is not available in [" + classDef + "]:" + classDef.getFields()); | ||
| } | ||
| } else { | ||
| throw new IllegalStateException("Field access no supported on the object definition: " + context.objectDef); |
There was a problem hiding this comment.
Suggested change
| throw new IllegalStateException("Field access no supported on the object definition: " + context.objectDef); | |
| throw new IllegalStateException("Field access not supported on the object definition: " + context.objectDef); |
sourcegen-generator-bytecode/src/main/java/io/micronaut/sourcegen/ByteCodeGenerator.java
Outdated
Show resolved
Hide resolved
sourcegen-generator-bytecode/src/main/java/io/micronaut/sourcegen/ByteCodeGenerator.java
Outdated
Show resolved
Hide resolved
sourcegen-generator-bytecode/src/main/java/io/micronaut/sourcegen/SignatureWriterUtils.java
Outdated
Show resolved
Hide resolved
sourcegen-generator-bytecode/src/main/java/io/micronaut/sourcegen/ByteCodeGenerator.java
Outdated
Show resolved
Hide resolved
sourcegen-generator-bytecode/src/main/java/io/micronaut/sourcegen/ByteCodeGenerator.java
Outdated
Show resolved
Hide resolved
| if (context.objectDef == null) { | ||
| throw new IllegalStateException("Accessing 'super' is not available"); | ||
| } | ||
| generatorAdapter.loadThis(); |
There was a problem hiding this comment.
Why is it loadThis for super?
| ExpressionDef left, | ||
| ExpressionDef right) implements ExpressionDef { | ||
| @Override | ||
| public TypeDef type() { | ||
| return TypeDef.Primitive.BOOLEAN; | ||
| return left.type(); |
There was a problem hiding this comment.
Can this break something because 1.0f + 2.0d = 3.0d? I suppose users could explicitly cast to double if needed though.
| * @author Denis Stepanov | ||
| * @since 1.4 | ||
| */ | ||
| sealed interface ConditionExpressionDef extends ExpressionDef { |
There was a problem hiding this comment.
Maybe call this BooleanExpressionDef?
graemerocher
approved these changes
Nov 12, 2024
|
Please review it again.
Let's merge it and move from there |
graemerocher
requested changes
Nov 25, 2024
gradle.properties
Outdated
| @@ -1,4 +1,4 @@ | |||
| projectVersion=1.4.2-SNAPSHOT | |||
| projectVersion=1.4.900-SNAPSHOT | |||
There was a problem hiding this comment.
might want to revert this not sure what its for
There was a problem hiding this comment.
I change it to publish a local version, which will not likely conflict with an existing one
sourcegen-model/src/main/java/io/micronaut/sourcegen/model/FieldDef.java
Outdated
Show resolved
Hide resolved
sourcegen-model/src/main/java/io/micronaut/sourcegen/model/MethodDef.java
Show resolved
Hide resolved
sourcegen-model/src/main/java/io/micronaut/sourcegen/model/MethodDef.java
Outdated
Show resolved
Hide resolved
sourcegen-model/src/main/java/io/micronaut/sourcegen/model/MethodDef.java
Outdated
Show resolved
Hide resolved
| * @param objectDef The object definition | ||
| */ | ||
| public void writeObject(ClassVisitor classVisitor, ObjectDef objectDef) { | ||
| if (objectDef instanceof ClassDef classDef) { |
There was a problem hiding this comment.
like here instead of all this if/else it would be good to use inheritance and have different implementations for records, classes, interfaces etc.
| * @param statementDef The statement definition | ||
| * @param finallyBlock The runnable that should be invoked before any returning operation - return/throw | ||
| */ | ||
| public void pushStatement(GeneratorAdapter generatorAdapter, |
There was a problem hiding this comment.
this is another case that could do with refactoring. Something like:
StatementWriter.for(statementDef).write(generator, context, finallyBlock)
Comment on lines
1416
to
1422
| // if (context.objectDef instanceof ClassDef classDef) { | ||
| // if (!classDef.hasField(field.name()) && classDef.getProperties().stream().noneMatch(prop -> prop.getName().equals(field.name()))) { | ||
| // throw new IllegalStateException("Field '" + field.name() + "' is not available in [" + classDef + "]:" + classDef.getFields()); | ||
| // } | ||
| // } else { | ||
| // throw new IllegalStateException("Field access not supported on the object definition: " + context.objectDef); | ||
| // } |
There was a problem hiding this comment.
if this code is dead delete it
Comment on lines
1431
to
1440
| // if (context.objectDef == null) { | ||
| // throw new IllegalStateException("Accessing 'this' is not available"); | ||
| // } | ||
| // if (context.objectDef instanceof ClassDef classDef) { | ||
| // if (!classDef.hasField(field.name()) && classDef.getProperties().stream().noneMatch(prop -> prop.getName().equals(field.name()))) { | ||
| // throw new IllegalStateException("Field '" + field.name() + "' is not available in [" + classDef + "]:" + classDef.getFields()); | ||
| // } | ||
| // } else { | ||
| // throw new IllegalStateException("Field access not supported on the object definition: " + context.objectDef); | ||
| // } |
There was a problem hiding this comment.
if this code is dead delete it
| throw new UnsupportedOperationException("Unrecognized variable: " + variableDef); | ||
| } | ||
|
|
||
| private void pushConstant(GeneratorAdapter generatorAdapter, |
There was a problem hiding this comment.
Something like:
ConstantWriter.for(constant).write(generator)would be good
|
@graemerocher Refactored out statement/expression writers. Do you want to make the |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a way to generate the bytecode directly; currently, if added, it will generate bytecode instead of JAVA sources.
I have added the bytecode checker by default to find bugs directly; it might be an optional feature in the future.
I have copied existing tests for Java generator. The missing features:
Includes a lot of expression improvement and cleanup. Builders adjusted to invoke methods based on the original signature if generic.
I will experiment next in Core to see what is missing / not working.