Fix pageable queries with dynamic entity name #3245
+106
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radovanradic
commented
Nov 25, 2024
|
|
||
| private static Function<Object, Object> createEnvResolverValueMapper(Environment environment) { | ||
| return o -> { | ||
| PropertyPlaceholderResolver resolver = environment.getPlaceholderResolver(); |
There was a problem hiding this comment.
This is needed to replace default behavior from EnvironmentAnnotationValue which when finds property to resolve also expands strings when finds comma and this is causing this issue creating more query parts than actual parameters.
dstepanov
reviewed
Nov 25, 2024
| @JdbcRepository(dialect = Dialect.H2) | ||
| public interface CustomEntityRepository extends CrudRepository<CustomEntity, Long> { | ||
| Slice<CustomEntity> findAll(Pageable pageable); | ||
|
|
||
| Page<CustomEntity> findByNameIn(List<String> names, Pageable pageable); |
There was a problem hiding this comment.
Can you please add an example of a custom query with IN that does have an expression
There was a problem hiding this comment.
It might fix this issue as well #2959
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is potential fix for issue when entity name has configurable value and uses
Pageablein find.