document and add example using unmarshaler interface #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ideas welcome for a simpler example. |
korylprince
reviewed
Nov 27, 2024
example_unmarshaler_test.go
Outdated
Comment on lines
58
to
59
| // Example_unmarshaler demonstrates using structs that use the Unmarshaler interface. | ||
| func Example_unmarshaler() { |
There was a problem hiding this comment.
If this is renamed ExampleUnmarshaler, it will be come an example on the interface instead of a package-level example.
There was a problem hiding this comment.
Huh. That was my goal! I tried to find examples and docs of how to do that, but came up empty. Was that documented somewhere?
There was a problem hiding this comment.
This blog post is what I was going off of: https://go.dev/blog/examples
There was a problem hiding this comment.
Yeah, that's what I read. I guess I didn't extend the function naming from the non-whole file example to the whole-file in my head. 🤷 Thanks!
korylprince
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14.