chore: replace for loop with call to copy (#2678) #140
asimAnnotations
12 errors and 10 warnings
|
Lint:
api/client/client.go#L14
import 'github.com/gorilla/websocket' is not allowed from list 'Main' (depguard)
|
|
Lint:
api/client/client.go#L125
should rewrite http.NewRequestWithContext or add (*Request).WithContext (noctx)
|
|
Lint:
api/client/client.go#L193
response body must be closed (bodyclose)
|
|
Lint:
api/router/util/compile.go#L89
Consider pre-allocating `ops` (prealloc)
|
|
Lint:
api/router/util/parse.go#L1
ST1000: at least one file in a package should have a package comment (stylecheck)
|
|
Lint:
api/router/util/parse.go#L54
declarations should never be cuddled (wsl)
|
|
Lint:
api/router/util/parse.go#L55
variable name 'st' is too short for the scope of its usage (varnamelen)
|
|
Lint:
api/router/util/parse.go#L148
for statement without condition should never be cuddled (wsl)
|
|
Lint:
api/router/util/parse.go#L150
error is not nil (line 149) but it returns nil (nilerr)
|
|
Lint:
api/router/util/parse.go#L234
error is not nil (line 233) but it returns nil (nilerr)
|
|
Summary Report
Process completed with exit code 1.
|
|
Unit Tests
Process completed with exit code 1.
|
|
Lint:
api/internal/proto/message.pb.go#L1
package-comments: should have a package comment (revive)
|
|
Lint:
api/internal/proto/message.pb.go#L3
exported: exported type Message should have comment or be unexported (revive)
|
|
Lint:
api/internal/proto/message.pb.go#L7
exported: exported method Message.ProtoMessage should have comment or be unexported (revive)
|
|
Lint:
api/internal/proto/message.pb.go#L9
exported: exported method Message.Reset should have comment or be unexported (revive)
|
|
Lint:
api/internal/proto/message.pb.go#L17
exported: exported method Message.Marshal should have comment or be unexported (revive)
|
|
Lint:
api/internal/proto/message.pb.go#L21
exported: exported method Message.Unmarshal should have comment or be unexported (revive)
|
|
Lint:
api/internal/proto/message.pb.go#L26
exported: exported function NewMessage should have comment or be unexported (revive)
|
|
Lint:
api/resolver/grpc/grpc.go#L40
unused-parameter: parameter 'opts' seems to be unused, consider removing or renaming it as _ (revive)
|
|
Lint:
api/resolver/resolver.go#L10
exported: exported var ErrNotFound should have comment or be unexported (revive)
|
|
Lint:
api/router/util/compile.go#L1
package-comments: should have a package comment (revive)
|