bump urfave cli & fix race condition (#2659) #126
asimAnnotations
12 errors and 10 warnings
|
Lint:
api/api.go#L148
ifElseChain: rewrite if-else to switch statement (gocritic)
|
|
Lint:
api/api_test.go#L8
cognitive complexity 51 of func `TestEncoding` is high (> 30) (gocognit)
|
|
Lint:
api/client/client.go#L14
import 'github.com/gorilla/websocket' is not allowed from list 'Main' (depguard)
|
|
Lint:
api/client/client.go#L125
should rewrite http.NewRequestWithContext or add (*Request).WithContext (noctx)
|
|
Lint:
api/client/client.go#L193
response body must be closed (bodyclose)
|
|
Lint:
api/default.go#L50
Error return value is not checked (errcheck)
|
|
Lint:
api/default.go#L52
return statements should not be cuddled if block has more than two lines (wsl)
|
|
Lint:
api/handler/api/api.go#L26
Function 'ServeHTTP' is too long (86 > 80) (funlen)
|
|
Lint:
api/handler/api/api.go#L40
Error return value of `w.Write` is not checked (errcheck)
|
|
Lint:
api/handler/api/api.go#L55
Error return value of `w.Write` is not checked (errcheck)
|
|
Summary Report
Process completed with exit code 1.
|
|
Unit Tests
Process completed with exit code 1.
|
|
Lint:
api/api.go#L16
exported: comment on exported type Api should be of the form "Api ..." (with optional leading article) (revive)
|
|
Lint:
api/api.go#L18
var-naming: type Api should be API (revive)
|
|
Lint:
api/api.go#L182
var-naming: func NewApi should be NewAPI (revive)
|
|
Lint:
api/default.go#L19
var-naming: func newApi should be newAPI (revive)
|
|
Lint:
api/default.go#L78
if-return: redundant if ...; err != nil check, just return error instead. (revive)
|
|
Lint:
api/handler/http/http_test.go#L17
var-naming: func testHttp should be testHTTP (revive)
|
|
Lint:
api/handler/rpc/rpc_test.go#L30
var-naming: type jsonUrl should be jsonURL (revive)
|
|
Lint:
api/handler/rpc/rpc_test.go#L35
var-naming: var jUrl should be jURL (revive)
|
|
Lint:
api/internal/proto/message.pb.go#L1
package-comments: should have a package comment (revive)
|
|
Lint:
api/internal/proto/message.pb.go#L3
exported: exported type Message should have comment or be unexported (revive)
|