Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a configurable handle of the cache to enable/disable by environ… #441

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

Neo1975
Copy link
Contributor

@Neo1975 Neo1975 commented Nov 29, 2024

Enabled a environment variable ENABLE_CACHE to address cache

Pull Request Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Description

PR Checklist

  • The commit message follows our guidelines included in the CONTRIBUTING.md
  • Tests for the changes have been added (for bug fixes / features)
  • Relevant CHANGELOG is updated

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@epessina epessina self-requested a review December 2, 2024 09:38
@coveralls
Copy link

coveralls commented Dec 2, 2024

Pull Request Test Coverage Report for Build 12143682318

Details

  • 9 of 11 (81.82%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 83.605%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/configurations.ts 2 4 50.0%
Totals Coverage Status
Change from base Build 11577473953: -0.4%
Covered Lines: 524
Relevant Lines: 598

💛 - Coveralls

@epessina
Copy link
Contributor

epessina commented Dec 3, 2024

Hi @Neo1975 , thanks for your contribution!

The PR looks good, could you just resolve the linting errors? Thanks!

@Neo1975
Copy link
Contributor Author

Neo1975 commented Dec 3, 2024

@epessina fixed

@epessina epessina merged commit 44a83ec into micro-lc:main Dec 4, 2024
8 checks passed
@epessina
Copy link
Contributor

epessina commented Dec 4, 2024

@Neo1975 the feature is available on version 3.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants