Improved error handling on unsupported ACL expressions

CHANGELOG.md

@@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 - Development dependencies updated
 
+### Changed
+
+- Improved error handling on unsupported ACL expressions
+
 ## [3.0.5] - 2023-10-02
 
 ### Versioning

src/sdk/evaluate-acl.ts

@@ -72,7 +72,12 @@ const buildPluginFunction = (plugin: FilterableObject) => {
 const evaluatePluginExpression = (userGroupsObject: UserGroupsObject, userPermissionsObject: UserPermissionsObject) => {
   return (plugin: FilterableObject): boolean => {
     const expressionEvaluationFunction = buildPluginFunction(plugin)
-    return expressionEvaluationFunction(userGroupsObject, userPermissionsObject) as boolean
+
+    try {
+      return expressionEvaluationFunction(userGroupsObject, userPermissionsObject) as boolean
+    } catch (err) {
+      throw new Error(`Error evaluating expression "${plugin.aclExpression}"`)
+    }
   }
 }
 

src/sdk/test/evaluate-acl.test.ts

@@ -215,4 +215,9 @@ describe('Evaluate ACL', () => {
       expect(result).to.deep.equal(expected)
     })
   })
+
+  it('should throw if expression is invalid', () => {
+    expect(() => evaluateAcl({ aclExpression: 'invalid-expression' }, [], []))
+      .to.throw('Error evaluating expression "invalid-expression"')
+  })
 })