Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added connectionEndpoint parameter to subscriptionOptions #113

Merged

Conversation

n1te1337
Copy link
Contributor

This PR adds connectionEndpoint parameter to subscriptionOptions.

if specified, the connection endpoint will be registered with the connectionEndpoint value as opposed to extracted from the event payload (as ${domainName}/${stage}). Useful when using API Gateway Custom Domains.

Closes #112

@michalkvasnicak
Copy link
Owner

@n1te1337 thank you very much! 👍

@michalkvasnicak michalkvasnicak merged commit 54b59fc into michalkvasnicak:master Aug 24, 2020
@n1te1337
Copy link
Contributor Author

@michalkvasnicak no worries, happy to help. Out of curiosity, how often do you cut new releases?

@michalkvasnicak
Copy link
Owner

@n1te1337 basically every time there is something to release I release it. One thing I'd like to mention is that if you use this library in production and you're happy with it, please consider mentioning your project/company in #106 🙂

@michalkvasnicak
Copy link
Owner

Also version 1.0.0-alpha.16 is released.

@n1te1337
Copy link
Contributor Author

@michalkvasnicak thanks a lot!

One thing I'd like to mention is that if you use this library in production and you're happy with it, please consider mentioning your project/company in #106 🙂

That's the plan, it's still WIP but I'll add it there when it's live

PS. Just tried the new version and works as expected with API Gateway Custom Domains 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Appending Stage name to the Endpoint causes AccessDeniedException when using APIGW Custom Domains
2 participants