Enhance Type Hinting for WebSocket Connection #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Enhance type hinting for 'connect' to improve IDE support"
|
@kevinheavey tests seem to pass. Looks safe to merge? |
michael-sola
approved these changes
Jun 10, 2024
michaelhly
approved these changes
Jun 10, 2024
michaelhly
requested review from
michael-sola
and removed request for
michael-sola
kevinheavey
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the type hinting of the
connectmethod inwebsocket_api.pyto returnSolanaWsClientProtocolinstead of the generalWebSocketClientProtocol. This change helps improve IDE support and developer experience by enabling better autocompletion and type checking for specific methods likelogs_subscribethat are available onSolanaWsClientProtocol.This addresses the issue #434 where there was a lack of autocompletion support in IDEs due to incorrect type hinting.