000: Refactor scale canvas method

michaeldzjap · Jan 7, 2022 · e40a20c · e40a20c
1 parent 1965480
commit e40a20c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/__tests__/SignaturePad.test.tsx b/__tests__/SignaturePad.test.tsx
@@ -193,7 +193,6 @@ describe('Component', () => {
 
         it('adds the resize event listener on mount', () => {
             const spy = jest.spyOn(window, 'addEventListener');
-
             const signaturePad = mount<SignaturePad>(<SignaturePad />);
 
             expect(spy).toHaveBeenCalledWith('resize', Reflect.get(signaturePad.instance(), 'callResizeHandler'));

diff --git a/src/SignaturePad.tsx b/src/SignaturePad.tsx
@@ -67,7 +67,7 @@ class SignaturePad extends React.PureComponent<Props, State> {
 
             this.signaturePad = new SigPad(canvas, this.props.options);
 
-            this.scaleCanvas();
+            this.scaleCanvas(canvas);
         }
     }
 
@@ -318,19 +318,20 @@ class SignaturePad extends React.PureComponent<Props, State> {
      * @return {void}
      */
     handleResize(): void {
-        this.scaleCanvas();
+        const canvas = this.canvasRef.current;
+
+        if (canvas) {
+            this.scaleCanvas(canvas);
+        }
     }
 
     /**
      * Scale the canvas.
      *
+     * @param {HTMLCanvasElement} canvas
      * @return {void}
      */
-    scaleCanvas(): void {
-        const canvas = this.canvasRef.current;
-
-        if (!canvas) return;
-
+    scaleCanvas(canvas: HTMLCanvasElement): void {
         const ratio = Math.max(window.devicePixelRatio || 1, 1);
         const width = (this.props.width || canvas.offsetWidth) * ratio;
         const height = (this.props.height || canvas.offsetHeight) * ratio;