Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing way to decide what method to look at as a condition to validation had 2 issues:
ActiveRecord
it couldn't use the methodwill_save_change_to_encrypted_password?
However projects with a mongo database will be supporting this from version 8.1.0 https://jira.mongodb.com/browse/MONGOID-4528ActiveRecord
and another using mongo before version 8.1.0. In this caseActiveRecord
would be defined, however not on the model if the user model (resource
) is a mongo based model. It would throw an error of undefined method.The simple fix is to just check that the method exists.
Test passes with the fix:
Thanks for creating and maintaining the gem.