Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add biome for standardization, ensure the builder reports errors correctly #72

Merged
merged 9 commits into from
Dec 15, 2023
Merged

fix: add biome for standardization, ensure the builder reports errors correctly #72

merged 9 commits into from
Dec 15, 2023

Conversation

michaelangeloio
Copy link
Owner

@michaelangeloio michaelangeloio commented Dec 15, 2023 •
edited
Loading

summary

  • previously the builder.ts wouldn't exit code >0 on an error. This PR fixes that
  • The formatting was all over the place, added biome to ensure it's correct
  • type check is now enabled on server/client packages.
  • fixes bug in server that if no settings are found, use defaults

@michaelangeloio michaelangeloio changed the title feat: initial neovim support feat: initial neovim support Dec 15, 2023
@michaelangeloio michaelangeloio changed the title feat: initial neovim support fix: add biome for standardization, ensure the builder reports errors correctly Dec 15, 2023
@michaelangeloio michaelangeloio merged commit 0d18392 into main Dec 15, 2023
2 checks passed
@michaelangeloio michaelangeloio deleted the neovim-guide branch December 15, 2023 17:01
@github-actions github-actions bot mentioned this pull request Dec 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@michaelangeloio