Added handling for custom databases #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, can you bump the version of mirtop and add it to the change log so Conda update the version? |
|
Thank you, some tests are failing. I think it is about the new argument need to be added to all the test, I can play with this next Friday if you don't have the time. Thanks! |
nschcolnicov
force-pushed
the
database_fix
branch
from
1e82e78
to
693b7d8
Compare
nschcolnicov
force-pushed
the
database_fix
branch
2 times, most recently
from
1051b5c
to
55e8fbc
Compare
nschcolnicov
force-pushed
the
database_fix
branch
from
5414112
to
4405d3a
Compare
|
Hi @lpantano I updated the files and ran the tests locally, should be working now. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to address this issue:
#90
The database provided via argument is now being taken into account, and I updated the code so that it tries to parse any custom database using either mirbase or mirgenedb parsing, if neither work, it will now display an error message saying that there is no available parser for the custom database
@lpantano