fix(flac): don't throw bad_compression error as this loses metadata

mhx · Dec 20, 2023 · 7363006 · 7363006
1 parent b61662c
commit 7363006
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/dwarfs/compression/flac.cpp b/src/dwarfs/compression/flac.cpp
@@ -331,9 +331,10 @@ class flac_block_compressor final : public block_compressor::impl {
       DWARFS_THROW(runtime_error, "[FLAC] failed to finish encoder");
     }
 
-    if (compressed.size() >= data.size()) {
-      throw bad_compression_ratio_error();
-    }
+    // XXX: don't throw this as we're losing metadata
+    // if (compressed.size() >= data.size()) {
+    //   throw bad_compression_ratio_error();
+    // }
 
     compressed.shrink_to_fit();