Ppass cwd to linter command #605
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thunderer199
force-pushed
the
feat/pass-cwd-to-linter-cmd
branch
from
c688eef to
cb6edd7
Compare
|
Hey @thunderer199 FYI, please note I opened another PR which touches |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node.js linters (eslint, stylelint, etc) run binary from relative
node_modulesthat depend on the working directory. But not always working directory hasnode_modules, in the case of monorepo it can be some sub-folder.The lint run command already has
cwdoption, but doesn't pass it tocmdcommand.The fix is passing opts to linter
cmdto properly calculate the path tonode_modulesif it's not in working directory.