Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ESLint linter expects different output #415

Closed
wants to merge 2 commits into from

Conversation

pavkam
Copy link

@pavkam pavkam commented Oct 14, 2023

This PR fixes ESLint linter parsing. Tested on ESLint v8.42.0.

The expected format is:

[
  {
    "filePath": "<full_file_path>",
    "messages": [
      {
        "ruleId": "simple-import-sort/imports",
        "severity": 1,
        "message": "Run autofix to sort these imports!",
        "line": 1,
        "column": 1,
        "nodeType": null,
        "messageId": "sort",
        "endLine": 14,
        "endColumn": 45,
        "fix": {
          "range": [0, 456],
          "text": "<... fix ...>"
        }
      }
    ],
    "suppressedMessages": [],
    "errorCount": 0,
    "fatalErrorCount": 0,
    "warningCount": 1,
    "fixableErrorCount": 0,
    "fixableWarningCount": 1,
    "source": "<... original ...>",
    "usedDeprecatedRules": []
  }
]

@sQVe
Copy link
Contributor

sQVe commented Oct 14, 2023

👋🏼,

Sorry about the issue @pavkam. I have created a PR that fixes the issues I introduced for the eslint and eslint_d linters. The test is also updated with the correct JSON output.

See #416.

@pavkam pavkam closed this Oct 15, 2023
@pavkam pavkam deleted the patch-1 branch October 18, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants