Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support end col for eslint #409

Merged
merged 4 commits into from
Oct 14, 2023
Merged

fix: support end col for eslint #409

merged 4 commits into from
Oct 14, 2023

Conversation

sQVe
Copy link
Contributor

@sQVe sQVe commented Oct 12, 2023 •
edited
Loading

This PR aims to add end_col support for the eslint and eslint_d linters.

See #394 for background.

@sQVe sQVe marked this pull request as ready for review October 12, 2023 20:10
@sQVe
Copy link
Contributor Author

sQVe commented Oct 12, 2023

Do note that I haven't had the time to verify if the altered test passes locally, since it's getting late. I would preferably verify it via CI, if possible.

@sQVe
Copy link
Contributor Author

sQVe commented Oct 13, 2023

Ouff, I thought I could rerun the tests after you approved them. I'll make sure to make the tests pass locally before making any further pushes. 👍🏼

@sQVe sQVe force-pushed the fix/support-end-col-for-eslint branch from 73c366f to b2a8edd Compare October 13, 2023 19:57
@sQVe
Copy link
Contributor Author

sQVe commented Oct 13, 2023

Tests pass locally now 👍🏼

mfussenegger
mfussenegger reviewed Oct 14, 2023
View reviewed changes
lua/lint/linters/eslint.lua Outdated Show resolved Hide resolved
lua/lint/linters/eslint.lua Outdated Show resolved Hide resolved
@mfussenegger mfussenegger merged commit 001eb1e into mfussenegger:master Oct 14, 2023
3 checks passed
@sQVe sQVe deleted the fix/support-end-col-for-eslint branch October 14, 2023 11:15
@sQVe sQVe mentioned this pull request Oct 14, 2023
Merged
mfussenegger pushed a commit that referenced this pull request Oct 17, 2023
@sQVe
Fix parsing regression in eslint(d) (#416)
7ac6307 
Follow up to #409
mfussenegger added a commit that referenced this pull request Oct 17, 2023
@mfussenegger
Revert "Add end_col to results of eslint/eslintd (#409)"
22b235f 
This reverts commit 001eb1e.
mfussenegger added a commit that referenced this pull request Oct 17, 2023
@mfussenegger
Revert broken eslint changes (#419)
749e895 
* Revert "Fix parsing regression in eslint(d) (#416)"

This reverts commit 7ac6307.

* Revert "Add end_col to results of eslint/eslintd (#409)"

This reverts commit 001eb1e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfussenegger mfussenegger mfussenegger left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sQVe @mfussenegger