Refactor and reintroduce diurnal processing #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
related issue #926 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main-dev #927 +/- ##
============================================
- Coverage 79.71% 79.68% -0.04%
============================================
Files 103 103
Lines 17736 17747 +11
============================================
+ Hits 14139 14141 +2
- Misses 3597 3606 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
jgriesfeller
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the chat @jgriesfeller mentioned "the diurnal cycle analysis does not seem to work anymore (no files in ts/diurnal although it was switched on and hourly data was there as well... ) and also no mentioning of the word diurnal in the log". Some how this code got dropped during refactoring so I am reintroducing it, with some modification to align with the new styling