Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test for working aeroval diurnal cycle analysis to CI #926

Open
jgriesfeller opened this issue Oct 13, 2023 · 2 comments · May be fixed by #1403
Open

add test for working aeroval diurnal cycle analysis to CI #926

jgriesfeller opened this issue Oct 13, 2023 · 2 comments · May be fixed by #1403
Assignees
@jgriesfeller
Labels
testing
Milestone
m2024-12

Comments

@jgriesfeller
Copy link
Member

the diurnal cycle analysis has just been accidentially removed from main-dev during a bigger than ususal PR. This slipped throuigh testing because there is no test for it.
Because it's a rarely used feature but also a feature that is important when it's needed, we should have a test if it's still working in CI.
Needs hourly model and obs data (example vmrno2 from EBAS and EMEP data from here:
/lustre/storeB/project/fou/kl/CAMS2_40/task4041/EMEP.cams2.40.p2/

The model data needs to be much coarser to be small enough for CI

aeroval option to set: use_diurnal=True
@jgriesfeller jgriesfeller mentioned this issue Oct 13, 2023
Merged
@lewisblake
Copy link
Member

One idea is that if it is too big in memory due to hourly data would be to test that this code exists. We could ping it, and mark the test as expecting to fail for no data (or something else)

@lewisblake lewisblake assigned jgriesfeller and unassigned avaldebe Jul 1, 2024
@lewisblake lewisblake added this to the m2024-09 milestone Jul 1, 2024
@heikoklein heikoklein modified the milestones: m2024-09, m2024-10 Sep 10, 2024
@lewisblake lewisblake modified the milestones: m2024-10, m2024-11 Oct 7, 2024
@lewisblake
Copy link
Member

General comment: It could be worth thinking about having (at least) two types of tests: unit tests, and and tests which take more time and should be run locally (not on CI) at the frequency closer to the release schedule, not necessarily during PRs. Would be useful for this at PM ratio tests.

@heikoklein heikoklein modified the milestones: m2024-11, m2024-12 Nov 8, 2024
@jgriesfeller jgriesfeller linked a pull request Nov 12, 2024 that will close this issue
Draft
9 tasks
@jgriesfeller jgriesfeller linked a pull request Nov 12, 2024 that will close this issue
add aeroval configurations to be run on CI #1403
Draft
9 tasks
@jgriesfeller jgriesfeller removed a link to a pull request Nov 12, 2024
add aeroval configurations to be run on CI #1403
Draft
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgriesfeller jgriesfeller

Labels
testing
Projects
None yet
Milestone
m2024-12
Development

Successfully merging a pull request may close this issue.

add aeroval configurations to be run on CI metno/pyaerocom
4 participants
@heikoklein @avaldebe @jgriesfeller @lewisblake