Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue236 update #249

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Issue236 update #249

merged 3 commits into from
Nov 13, 2024

Conversation

mortenwh
Copy link
Collaborator

Summary: closes #236

Related issue:

Suggested reviewer(s):

Reviewer checklist:

  • The headers of all files contain a reference to the repository license
  • 100% test coverage of new code - meaning:
    • The overall test coverage increased or remained the same as before
    • Every function is accompanied with a test suite
    • Tests are both positive (testing that the function work as intended with valid data) and negative (testing that the function behaves as expected with invalid data, e.g., that correct exceptions are thrown)
    • Functions with optional arguments have separate tests for all options
  • Examples are supported by doctests
  • All tests are passing
  • All names (e.g., files, classes, functions, variables) are explicit
  • Documentation (as docstrings) is complete and understandable

The checklist is based on the S-ENDA conventions and definition of done (see General Conventions). The above points are not necessarily relevant to all contributions. In that case, please add a short explanation to help the reviewer.

@charlienegri
Copy link
Contributor

the change means that there will be no more post request containing an xml string with an csw:Update </csw:Update> block, is that intended?

@mortenwh
Copy link
Collaborator Author

Well, the intention is that the update request to the API stays as it is but because it is tricky to use pycsw update transaction correctly, we choose to delete and reinsert instead. But that should happen behind the scenes... The xml string is used in the request to the pycsw transaction, right? So that is not used anymore.

@mortenwh mortenwh merged commit 8b47573 into main Nov 13, 2024
5 checks passed
@mortenwh mortenwh deleted the issue236_update branch November 13, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pycsw_dist update is failing
2 participants