Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for Meteor 1.4 #108

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update for Meteor 1.4 #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
561fe2b
Update Node to 4.4.7 for Meteor 1.4
Ben305 Jul 27, 2016
29a4fe2
Trigger rebuilding npm dependencies (Meteor 1.4)
Ben305 Jul 27, 2016
14bb767
Bump PhantomJS to 2.1.1
Ben305 Jul 27, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion base/scripts/lib/install_node.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/bin/bash
set -e
NODE_VERSION=0.10.43
NODE_VERSION=4.4.7
NODE_ARCH=x64

# check we need to do this or not
Expand Down
2 changes: 1 addition & 1 deletion base/scripts/lib/install_phantomjs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
set -e
apt-get -y install libfreetype6 libfreetype6-dev fontconfig
ARCH=`uname -m`
PHANTOMJS_VERSION=1.9.8
PHANTOMJS_VERSION=2.1.1
PHANTOMJS_TAR_FILE=phantomjs-${PHANTOMJS_VERSION}-linux-${ARCH}.tar.bz2

cd /usr/local/share/
Expand Down
4 changes: 2 additions & 2 deletions base/scripts/run_app.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@ if [ -d /bundle ]; then
cd /bundle
tar xzf *.tar.gz
cd /bundle/bundle/programs/server/
npm i
npm install --unsafe-perm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the --unsafe-perm? Also, this should probably have --production so things like linters and testing packages don't needlessly get installed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without --unsafe-perm it did not work, this solution was provided in in issue from the Meteor repository

cd /bundle/bundle/
elif [[ $BUNDLE_URL ]]; then
cd /tmp
curl -L -o bundle.tar.gz $BUNDLE_URL
tar xzf bundle.tar.gz
cd /tmp/bundle/programs/server/
npm i
npm install --unsafe-perm
cd /tmp/bundle/
elif [ -d /built_app ]; then
cd /built_app
Expand Down