Benchpress/oss benchmark #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since it builds on top of the nginx branch, it shows the nginx changes. You can ignore those as you already reviewed them. New changes are from commit 70a034f forward. This link shows only that subset: |
meteorfox
force-pushed
the
benchpress/oss-benchmark
branch
from
75b0a5a to
e418ca8
Compare
adhanotia
approved these changes
May 17, 2018
| #!/bin/bash | ||
| set -e | ||
| set -x | ||
|
|
There was a problem hiding this comment.
Add prerequisites here. Libraries we need to install on our test hosts before we can run this script.
| # Installs HHVM's oss-performance under benchmarks/ | ||
| # | ||
|
|
||
| HHVM_PATH=${HHVM_PATH:-'hhvm'} |
There was a problem hiding this comment.
Does this assume hhvm is installed or we are installing it using benchpress before calling the oss-performance installer?
| set -e | ||
| set -x | ||
|
|
||
| SIEGE_GIT_REPO='https://github.com/JoeDog/siege.git' |
There was a problem hiding this comment.
Lets add prerequisite library section here.
|
Updates:
|
meteorfox
force-pushed
the
benchpress/oss-benchmark
branch
from
3e48c29 to
223aed6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the oss-benchmark.
Please review but don't merge, as I want to merge to upstream.