improve circle ci tests #161
Conversation
|
@DominikGuzei: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
|
Interesting. Can you explain the rationale in moving the chimp command out of |
|
@tmeasday that was done because i ran into several issues with chimp and Node.js 0.10.x that Meteor is using. So the problem is that if you run Node via Here are the related Github issues and discussions: Bottom line: Meteor really has to upgrade to use up-to-date Node.js versions soon. Until then, we cannot use the |
… its package.json. We have Node 0.10.45. So, we have to specify using <1.10.1 for now.
Used the NPM "denodeify" package to supply an equivalent. This package has no other dependencies and uses the global Promise definition, so hopefully it won't run into problems with Fibers.
… CommonJS "require".
…able ESLint to tolerate conditional imports and exports.
in imports/startup/client/routes.app-test.js: 35:22 error Unexpected block statement surrounding arrow body arrow-body-style
[email protected] incorporates import-js/eslint-plugin-import#415 to fix a clash between eslint-plugin-import and eslint-plugin-meteor that was only occurring when running under the NPM/Node combination used by the Meteor 1.3.4.x series of releases.
Use `meteor npm install`
…vingston/todos into rhettlivingston-update-to-meteor-1.3.4.4 Conflicts: imports/startup/client/routes.app-test.js
|
Makes sense @DominikGuzei. We just updated the PS we now have a |
|
damn … that's why you should never use rebase. Just screwed up the whole PR 😢 |
No description provided.