Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken deno runtime secret injection #946

Merged
merged 2 commits into from
Dec 25, 2024
Merged

Conversation

Yohe-Am
Copy link
Contributor

@Yohe-Am Yohe-Am commented Dec 24, 2024

  • Bumps to 0.5.0-rc.9
  • Fixes bug with deno secret injection

Migration notes


  • The change comes with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.72%. Comparing base (37f51aa) to head (6f691e4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/typegate/src/runtimes/deno/deno.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #946      +/-   ##
==========================================
+ Coverage   77.69%   77.72%   +0.02%     
==========================================
  Files         153      153              
  Lines       19096    19096              
  Branches     1924     1924              
==========================================
+ Hits        14837    14842       +5     
+ Misses       4235     4231       -4     
+ Partials       24       23       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Yohe-Am Yohe-Am requested review from Natoandro and zifeo December 25, 2024 09:32
@zifeo zifeo merged commit 6b68642 into main Dec 25, 2024
12 of 13 checks passed
@zifeo zifeo deleted the chore/ready-0.5.0-rc.9 branch December 25, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants