fix: re-enable macos-latest cli-compat test job #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #608 +/- ##
=======================================
Coverage 74.14% 74.14%
=======================================
Files 111 111
Lines 12425 12425
Branches 1313 1313
=======================================
Hits 9213 9213
Misses 3192 3192
Partials 20 20 ☔ View full report in Codecov by Sentry. |
Yohe-Am
force-pushed
the
fix/macos-compat-ci-job
branch
from
7d15ded to
b3ce726
Compare
|
The openssl build bug seems to be related to rust-lang/git2-rs#1026. Updating the lockfile entries for openssl-sys seems to have fixed this. There was also an issue related with the wasmtime python package that a version bump fixed. |
|
@afmika was there anything else to change when upgrading wasmtime? |
I was worried about the host interface but there seems to be no issues 👍 |
zifeo
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes and enables the broken job.
Motivation and context
Job was disabled earlier to mysterious breakages.
Migration notes
No changes required
Checklist