Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): long running discovery #599

Merged
merged 81 commits into from
Mar 18, 2024
Merged

Conversation

michael-0acf4
Copy link
Contributor

@michael-0acf4 michael-0acf4 commented Feb 23, 2024

Delegate serialize, deploy work to SDK.

Motivation and context

Remove duplicate logic, thinking of cli as a convenience on top of the SDK.

Migration notes

When meta cli is used, Migration files are unpacked/resolved relative to the typegraph's path, not the process's workdir.

Checklist

  • The change come with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

@michael-0acf4 michael-0acf4 changed the title feat(sdk): long running discovery feat(cli): long running discovery Feb 24, 2024
examples/sample/example.ts Outdated Show resolved Hide resolved
meta-cli/src/com/server.rs Outdated Show resolved Hide resolved
meta-cli/src/cli/serialize.rs Outdated Show resolved Hide resolved
meta-cli/src/typegraph/loader/mod.rs Outdated Show resolved Hide resolved
Yohe-Am
Yohe-Am previously approved these changes Mar 13, 2024
Copy link
Contributor

@Yohe-Am Yohe-Am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You weren't kidding about that Cargo.lock diff. Good stuff, changes were way more contained than I expected.

typegraph/node/sdk/src/typegraph.ts Show resolved Hide resolved
examples/deploy/deploy.py Outdated Show resolved Hide resolved
examples/deploy/deploy.py Show resolved Hide resolved
meta-cli/src/cli/codegen.rs Outdated Show resolved Hide resolved
meta-cli/src/cli/serialize.rs Outdated Show resolved Hide resolved
meta-cli/src/cli/serialize.rs Outdated Show resolved Hide resolved
examples/deploy/deploy.mjs Show resolved Hide resolved
Yohe-Am
Yohe-Am previously approved these changes Mar 14, 2024
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 73.75%. Comparing base (772dc80) to head (df9277f).

Files Patch % Lines
typegate/src/runtimes/typegate.ts 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #599      +/-   ##
==========================================
- Coverage   73.79%   73.75%   -0.04%     
==========================================
  Files         110      110              
  Lines       12512    12513       +1     
  Branches     1312     1310       -2     
==========================================
- Hits         9233     9229       -4     
- Misses       3259     3264       +5     
  Partials       20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

meta-cli/src/com/server.rs Show resolved Hide resolved
@michael-0acf4 michael-0acf4 merged commit 97caf65 into main Mar 18, 2024
12 checks passed
@michael-0acf4 michael-0acf4 deleted the sdk-long-running-discovery branch March 18, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants