Implement new syntax. Closes #1. #5
Conversation
|
@sun1x ok, I'll review it in a few days. |
| @@ -1 +1,2 @@ | |||
| Timur Shemsedinov <[email protected]> | |||
| Sergey Nanovsky <[email protected]> | |||
There was a problem hiding this comment.
That would not be related to this PR :)
I am okay with @sun1x adding himself to the list in his first PR, though I would not say it is a good thing to do generally. But adding other people should definitely be done separately.
| @@ -0,0 +1,48 @@ | |||
| /* eslint-disable no-template-curly-in-string */ | |||
There was a problem hiding this comment.
Why underscores __tests__ ?
There was a problem hiding this comment.
That's how it is usually done in Jest, but it is not a requirement. If I recall correctly, you may as well name the directory as you wish and just name your test files as *.test.js or something like that.
There was a problem hiding this comment.
Should I change it?
By default, Jest uses this regex to detect test files.
|
I've just enabled Travis for this repo, so I'm going to close and reopen this PR to trigger a build. |
Here is my implementation, as there is no progress in #4.
@aqrln @primeare, check it please.