Use eslint-config-metarhia and fix linting issues #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nechaido
approved these changes
Oct 19, 2018
tshemsedinov
approved these changes
Oct 19, 2018
lundibundi
approved these changes
Oct 19, 2018
bin/cli.js
Outdated
| }; | ||
|
|
||
| const merge = (arr1 = [], arr2 = []) => common.merge(arr1, arr2); | ||
|
|
||
| const exclude = (files, filterArr) => | ||
| filterArr.map(path => path.replace('.', '\\.') | ||
| const exclude = (files, filterArr) => filterArr.map( |
There was a problem hiding this comment.
Could this wait for your newest addition to eslint-config-metarhia and then be changed to be on a new line. I think it's confusing to have it this way, I find it hard to distinguish map-function vs next chained calls and both of them have a lot of chaining but the main map is on 'the-other-line'.
belochub
force-pushed
the
use-eslint-config-metarhia
branch
from
303c23e
to
d23a6f5
Compare
lundibundi
approved these changes
Oct 28, 2018
belochub
added a commit
that referenced
this pull request
Oct 29, 2018
|
Landed in 61e3d94. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: metarhia/Metarhia#22