Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes
.eslintrc.yml
in favor of using theeslint-config-metarhia
package. Three rules are turned off here,because they trigger lots of linter errors:
arrow-parens
— forces consistent parens usage in arrow functionscomma-dangle
— forces VCS- and diff-friendly comma usagehandle-callback-err
— ensures the errors are handled instead ofbeing silently ignored
How these exceptions are handled further is outside the scope of this
commit/pull request, and they might need somewhat deeper investigation
than just considering the rules themselves. E.g., errors triggered by
handle-callback-err
may not necessarily mean that there's a lot ofplaces errors are not handled in metasync (though if that's indeed the
case, it will show nicely where to fix these bugs so that one doesn't
need to spot all of them manually), but it might be just that there's
some trouble with regex specified in this rule's settings.
One of the linter errors is handled in this commit though: there was a
require()
call pointing to a non-existent file, which is now fixed.Also,
eslint
package has been updated to match whatpeerDependencies
of
eslint-config-metarhia
require, andeslint-plugin-import
, whichis also a part of the config's
peerDependencies
, has been installed.