Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fee destination address #149

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Update fee destination address #149

merged 2 commits into from
Nov 1, 2024

Conversation

danenbm
Copy link
Contributor

@danenbm danenbm commented Oct 28, 2024

Notes

Hard code new addresss for fee destination and ownerless close destination.

Tests

Ran fee tests with local tests unignored.

     Running tests/fees.rs (target/debug/deps/fees-996c77c3186bac65)

running 12 tests
test fees::fee_manager_pdas_are_correct ... ok
test fees::charge_create::token_program ... ok
test fees::update_does_not_overwrite_flag::token_program ... ok
test fees::cannot_collect_fees_using_wrong_fee_destination::token_program ... ok
test fees::charge_create_metadata_v3 ... ok
test fees::collect_fees_burned_account::token_program ... ok
test fees::charge_create::token_2022_program ... ok
test fees::cannot_collect_fees_using_wrong_fee_destination::token_2022_program ... ok
test fees::update_does_not_overwrite_flag::token_2022_program ... ok
test fees::collect_fees_burned_account::token_2022_program ... ok
Transaction size: 964
test fees::collect_fees_max_accounts::token_program ... ok
Transaction size: 964
test fees::collect_fees_max_accounts::token_2022_program ... ok

test result: ok. 12 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.31s

Ran close js tests (changed test.skip to test.serial since they affect same wallet).

> ava "test/close/fungible.test.ts"


  ✔ it can close ownerless metadata for a fungible with zero supply and no mint authority (1.9s)
  ✔ it can close ownerless metadata for a fungible with zero supply and mint authority set to the system program (2s)
  ✔ it can close ownerless metadata for a fungible asset with zero supply and no mint authority (2s)
  ✔ it cannot close ownerless metadata for a fungible with non-zero supply and no mint authority (1.2s)
  ✔ it cannot close ownerless metadata for a fungible with zero supply and a mint authority (1.2s)
  ✔ it cannot close ownerless metadata for a fungible with wrong authority (1.6s)
  ✔ it cannot close ownerless metadata for a fungible with wrong destination (1.5s)
  ─

  7 tests passed
> ava "test/close/nonFungible.test.ts"


  ✔ it can close ownerless metadata for a non-fungible with zero supply (1.6s)
  ✔ it cannot close ownerless metadata for a non-fungible with non-zero supply (823ms)
  ✔ it cannot close ownerless metadata for a programmable non-fungible with non-zero supply (810ms)
  ✔ it cannot close ownerless metadata with wrong authority (799ms)
  ✔ it cannot close ownerless metadata with wrong destination (808ms)
  ✔ it can close ownerless metadata for a non-fungible edition with zero supply (2s)
  ✔ it cannot close ownerless metadata for a non-fungible edition with non-zero supply (1.2s)
  ✔ it cannot close ownerless metadata for a programmable non-fungible edition with non-zero supply (1.2s)
  ─

  8 tests passed

Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mpl-token-metadata-js-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2024 6:53pm

blockiosaurus
blockiosaurus previously approved these changes Nov 1, 2024
@danenbm danenbm merged commit 2878f77 into main Nov 1, 2024
11 checks passed
@danenbm danenbm deleted the danenbm/update-fee-dest branch November 1, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants