Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scenario
Combining
flickity
with multiples plugins, likeflickity-fullscreen
andflickity-as-nav-for
.Issue
Since we have
flickity
as a dependency, will extend flickity from it's ownnode_modules
instead of extending the one of the project'snode_modules
.This makes impossible to combine two plugins.
Solution
Define on the plugin,
flickity
as apeerDependency
.--
If you merge this, we should do the same on https://github.com/metafizzy/flickity-as-nav-for