PICARD-3000: Children's Music is shown as "Children'S Music" in Picard

[zytact]

Summary

• This is a…
  • Bug fix
  • Feature addition
  • Refactoring
  • Minor / simple change (like a typo)
  • Other
• Describe this change in 1-2 sentences:

Problem

• JIRA ticket (optional): PICARD-3000

Genre Children's Music is shown as Children'S Music using Python's title method.

Solution

Create a custom function to handle making the genre title case which also handles the apostrophe.

[phw]

Thanks for this patch. For this use case it should work. But I wonder if we should use a better function to begin with.

There is an existing title case function as scripting at https://github.com/metabrainz/picard/blob/master/picard/script/functions.py#L964

I think we should factor out the title casing functionality into a function in picard.util, e.g. just def titlecase(s). Then this function can be used both here for handling the genres and in the func_title scripting function.

This also allows to add tests for the title case function.

[zytact]

Thank you for looking into it. I think that would be best way to do it. If we use this approach should I create another separate PR for handling that?

[phw]

@zytact Would be allright to do this as part of this PR

[zas]

Nice fix & code improvement, LGTM.

[phw]

Thanks a lot for this contribution. Looks great. Just the initial titlize function added to track.py can now be removed. Then this is good to merge

[phw]

Thanks. LGTM