Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests with specific combination of required packages #2444

Merged
merged 2 commits into from
May 1, 2024

Conversation

phw
Copy link
Member

@phw phw commented May 1, 2024

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

Some of Picard's dependencies are optional or have alternatives (e.g. discid|python-libdiscid or charset-normalizer|chardet). CI testing currently only insufficiently tests for these scenarios.

Solution

Run tests with specific combination of required packages

This tests for tests passing with optional packages and alternative packages.

phw added 2 commits May 1, 2024 11:36
This tests for tests passing with optional packages and alternative
packages like discid|libdiscid or charset-normalizer|chardet
@phw phw assigned zas May 1, 2024
Copy link
Collaborator

@zas zas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phw phw merged commit 5d72950 into metabrainz:master May 1, 2024
45 checks passed
@phw phw deleted the test-requirements branch May 1, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants