Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated datetime.utcnow() with datetime.now(datetime.UTC) #2442

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Replace deprecated datetime.utcnow() with datetime.now(datetime.UTC) #2442

merged 1 commit into from
Apr 30, 2024

Conversation

phw
Copy link
Member

@phw phw commented Apr 30, 2024

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

datetime.utcnow is deprecated since Python 3.12, see https://docs.python.org/3/library/datetime.html#datetime.datetime.utcnow

@phw
Replace deprecated datetime.utcnow() with datetime.now(datetime.UTC)
8891f9c 
datetime.utcnow is deprecated since Python 3.12
@phw phw requested a review from zas April 30, 2024 09:33
zas
zas approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@zas zas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zas zas merged commit 6aa68cf into metabrainz:master Apr 30, 2024
41 checks passed
@phw phw deleted the datetime-utcnow-deprecation branch April 30, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zas zas zas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phw @zas