Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup defaults #2438

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Cleanup defaults #2438

merged 3 commits into from
Apr 30, 2024

Conversation

zas
Copy link
Collaborator

@zas zas commented Apr 29, 2024

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

  • JIRA ticket (optional): PICARD-XXX

Solution

Action

Additional actions required:

  • Update Picard documentation (please include a reference to this PR)
  • Other (please specify below)

@zas
Copy link
Collaborator Author

zas commented Apr 29, 2024

@phw can you test on macos (in case of)?

Also shouldn't DEFAULT_STARTING_DIR be the same as DEFAULT_CURRENT_BROWSER_PATH ? Current code makes them different on MacOs.

@zas zas requested a review from phw April 29, 2024 10:56
@zas zas force-pushed the cleanup_defaults branch from 5415974 to fbab1f1 Compare April 29, 2024 15:44
@zas zas marked this pull request as ready for review April 29, 2024 16:07
@zas zas requested a review from phw April 29, 2024 16:34
phw
phw approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@phw phw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on macOS, works as before. So let's merge it.

The handling of the default paths should indeed be changed a bit, I'll open a separate PR for this.

@phw phw merged commit 52656c7 into metabrainz:master Apr 30, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phw phw phw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zas @phw