PICARD-2875: Let the user select the auto backup directory in Maintenance Options #2430
Conversation
|
@rdswift please test this and feel free to improve, the idea is to let the user select the target directory instead of always loading the default one. |
zas
force-pushed
the
save_last_backup_dir
branch
from
45bb68f to
fc5f89b
Compare
Move UI code to _dialog_*() and reformat texts
zas
force-pushed
the
save_last_backup_dir
branch
from
7111529 to
2aa5561
Compare
There was a problem hiding this comment.
One other thing I noticed while testing was that if a non-existent directory was specified in the backup directory text box (for example /home/user/Documents/PicardBackups) and the settings saved with Make It So!, the setting (text box) would silently reset to the default. Perhaps when exiting the text box we could check if the specified directory exists and if not, pop up a dialog asking if the user wanted to create it. If the user selects to create it and it can't be created, then a dialog box should indicate that there was a problem. In that case, or if the user chooses to cancel creating the directory, then it should revert to the previously saved value (or the default value). In any case, it probably shouldn't reset to the default value silently.
Co-authored-by: Bob Swift <[email protected]>
Co-authored-by: Bob Swift <[email protected]>
Yes, I'm aware of it, I didn't want to make the thing too complicated. Instead of reverting to default we could just ignore the change. |
With notification? My concern is that something that the user entered (even if wrong) will be silently modified, so what is saved is not what they input and they aren't made aware of the change. |
This reverts commit 686df50.
…d revert back to last valid path
I added a notification and revert back to last valid path if it happens, not perfect, but better than nothing. A new directory can be created from the directory selector, so I don't think we should make things too complex and let the user creates the dir from this warning dialog. |
- expand automatic backup directory label and add trailing colon - move Load and Save buttons - add line to separate config file/directory from setting removal - change to sentence case for existing option label and buttons - add ellipses to buttons that open new dialogs/windows
Modify maintenance options page label text and layout
It looks good to me, merged, thanks! |
|
On that page I would also like to change the logic (and possibly layout slightly) so that you don't have to select the checkbox to view (scroll) the list of unused options. It seems I really didn't think the UI through as well as I should have when I set it up initially. 😊 In any event, I'll save that for a new PR later because it doesn't really apply to the subject of this PR. |
zas
changed the title
Summary
Problem
That's the directory used to saved configuration backups (auto & user).
Currently it is defaulting to Documents (depending on platform), but the user cannot change it.
Solution
Provide a way to select target directory and remember it between runs.
It is stored in a new setting named
autobackup_directory.Action
Additional actions required: