Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only register sys.excepthook if the app actually started #2428

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

zas
Copy link
Collaborator

@zas zas commented Apr 23, 2024

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

Without this patch, when running tests the crash message box may be displayed.
The issue appeared in d796b1e

  • JIRA ticket (optional): PICARD-XXX

Solution

With those changes, it will be displayed only if the app was actually started.

Action

Additional actions required:

  • Update Picard documentation (please include a reference to this PR)
  • Other (please specify below)

Without this patch, when running tests the crash message box may be displayed.
With those changes, it will be displayed only if the app was actually started.
@zas zas requested a review from phw April 23, 2024 09:44
Copy link
Member

@phw phw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good move, LGTM

Now we only need.to figure out why the crash dialog sometimes shows up twice. I had this happening, too.

@phw phw merged commit eec6513 into metabrainz:master Apr 24, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants