Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PICARD-2873: Fetch Search dialog cover art images after it was resized #2427

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

zas
Copy link
Collaborator

@zas zas commented Apr 23, 2024

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

In Album Search Dialog, scrolling table causes missing cover art images to be fetched, but it doesn't work if the dialog is resized and those cells made visible.
No signal is associated with this event, and therefore no code leading to fetching missing images is executed when it happens

Solution

  • create a new resized signal emitted every second
  • call AlbumSearchDialog.fetch_coverarts() when it happens

Action

Additional actions required:

  • Update Picard documentation (please include a reference to this PR)
  • Other (please specify below)

@zas zas marked this pull request as ready for review April 23, 2024 09:26
@zas zas requested review from phw and rdswift April 23, 2024 09:26
picard/ui/tablebaseddialog.py Outdated Show resolved Hide resolved
picard/ui/tablebaseddialog.py Show resolved Hide resolved
zas added 2 commits April 24, 2024 10:52
- create a new `resized` signal emitted every second
- call `AlbumSearchDialog.fetch_coverarts()` when it happens
Revamp signal emitters a bit to make it easier to override by a subclass
@zas zas force-pushed the fix_cover_art_cells branch from 3ed9af0 to 18c9ba5 Compare April 24, 2024 08:52
@zas zas merged commit 5f5b4e4 into metabrainz:master Apr 25, 2024
41 checks passed
@zas zas deleted the fix_cover_art_cells branch April 25, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants