Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed calls to QFileDialog options #2425

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

phw
Copy link
Member

@phw phw commented Apr 22, 2024

The code is invalid in PyQt6 and also just was supposed to set the standard options being set anyway.

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

Invalid call to get default QFileDialog options. This is unneeded anyway, as the dialog will use the default options regardless.

The code is invalid in PyQt6 and also just was supposed to set the
standard options being set anyway.
Copy link
Collaborator

@zas zas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM

@phw phw merged commit b7b43ca into metabrainz:master Apr 22, 2024
41 checks passed
@phw phw deleted the fix-qfiledialog-getopenfilenames branch April 22, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants