PICARD-2871: Get rid of QtCore.QObject.tagger
#2424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phw
reviewed
Apr 22, 2024
Instead of `QtCore.QObject.tagger`
zas
force-pushed
the
byebye_qtcore_qobject_tagger
branch
from
57b55d5 to
306b9a6
Compare
If app isn't passed just defaults to current application Use explicit keyword arguments
zas
force-pushed
the
byebye_qtcore_qobject_tagger
branch
from
306b9a6 to
3b6b90d
Compare
zas
changed the title
QtCore.QObject.taggerQtCore.QObject.tagger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Using
QtCore.QObject.taggeris a bit problematic and hacky.It was kept around for a long time, but it is now time to get rid of it.
Solution
Use
QtCore.QCoreApplication.instance()as Tagger class inherit from it anyway.Action
Additional actions required: